[Esbox-commits] r2028 - branches/work_Ed/org.maemo.esbox.vm.vmware/src/org/maemo/esbox/internal/api/vm/vmware

[eswartz at garage.maemo.org]

Author: eswartz
Date: 2009-08-27 17:00:03 +0300 (Thu, 27 Aug 2009)
New Revision: 2028

Modified:
   branches/work_Ed/org.maemo.esbox.vm.vmware/src/org/maemo/esbox/internal/api/vm/vmware/MaemoSDKVMDownloader.java
Log:
Fix some NPEs related to ESbox bug #4444.  (This doesn't really fix that bug but fixes some NPE cases.)

Modified: branches/work_Ed/org.maemo.esbox.vm.vmware/src/org/maemo/esbox/internal/api/vm/vmware/MaemoSDKVMDownloader.java
===================================================================
--- branches/work_Ed/org.maemo.esbox.vm.vmware/src/org/maemo/esbox/internal/api/vm/vmware/MaemoSDKVMDownloader.java	2009-08-27 12:53:22 UTC (rev 2027)
+++ branches/work_Ed/org.maemo.esbox.vm.vmware/src/org/maemo/esbox/internal/api/vm/vmware/MaemoSDKVMDownloader.java	2009-08-27 14:00:03 UTC (rev 2028)
@@ -80,10 +80,14 @@
 			fileSize = getSizeFor(downloadPage, downloadFile.getDescriptor().getName());
 			remoteURL = getLinkFor(downloadPage, downloadFile.getDescriptor().getName());
 		} catch (MalformedURLException e) {
-			Activator.getErrorLogger().logAndShowError("Invalid file URL", e);
-			return null;
+			throw new MicaException("Invalid file URL on " + MaemoSDKVMInfo.DOWNLOAD_PAGE, e);
 		}
 				
+		if (remoteURL == null) {
+			throw new MicaException("Cannot locate ''" + downloadFile.getDescriptor().getName() 
+					+ "'' on " + MaemoSDKVMInfo.DOWNLOAD_PAGE);
+		}
+		
 		return new Tuple(remoteURL, fileSize);
 	}
 	
@@ -347,7 +351,7 @@
 			monitor.beginTask(remoteURL.getFile(), remoteFileSize != 0 ? remoteFileSize : IProgressMonitor.UNKNOWN);
 			monitor.worked((int)downloadFile.getDownloadedSize());
 			
-			int bufferSize = 64*1054;//64KB
+			int bufferSize = 64*1024;//64KB
 			DownloadingThread thread = new DownloadingThread(in, out,bufferSize , progressMonitor, monitor);
 			thread.start();