[Esbox-commits] r1529 - in branches/work_Ed: org.maemo.esbox.scratchbox.core/src/org/maemo/esbox/internal/api/scratchbox/core/sdk org.maemo.esbox.scratchbox.sb1/src/org/maemo/esbox/internal/scratchbox/sb1/ui/adapters

[eswartz at garage.maemo.org]

Author: eswartz
Date: 2009-05-04 22:52:05 +0300 (Mon, 04 May 2009)
New Revision: 1529

Modified:
   branches/work_Ed/org.maemo.esbox.scratchbox.core/src/org/maemo/esbox/internal/api/scratchbox/core/sdk/AbstractScratchboxSDK.java
   branches/work_Ed/org.maemo.esbox.scratchbox.sb1/src/org/maemo/esbox/internal/scratchbox/sb1/ui/adapters/MaemoScratchbox1SDKManageTargetAdapter.java
Log:
Fix bug not refreshing targets when refreshing an SDK.  Add Javadoc to BaseSDK and BaseSDKTarget.  Make test classes match the behavior of other scratchbox SDKs.

Modified: branches/work_Ed/org.maemo.esbox.scratchbox.core/src/org/maemo/esbox/internal/api/scratchbox/core/sdk/AbstractScratchboxSDK.java
===================================================================
--- branches/work_Ed/org.maemo.esbox.scratchbox.core/src/org/maemo/esbox/internal/api/scratchbox/core/sdk/AbstractScratchboxSDK.java	2009-05-04 19:41:40 UTC (rev 1528)
+++ branches/work_Ed/org.maemo.esbox.scratchbox.core/src/org/maemo/esbox/internal/api/scratchbox/core/sdk/AbstractScratchboxSDK.java	2009-05-04 19:52:05 UTC (rev 1529)
@@ -51,6 +51,8 @@
 	public AbstractScratchboxSDK(IMachine machine, IPath location, String version, String name,
 			int versionNumber) {
 		super(machine, version, name);
+		if (location == null) 
+			throw new IllegalArgumentException();
 		this.installLocation = location;
 		this.versionNumberKey = versionNumber;
 		setCache(ScratchboxCacheUtils.getCache(this));
@@ -102,16 +104,6 @@
 		return true;
 	}
 
-	/*
-	 * (non-Javadoc)
-	 * 
-	 * @see org.maemo.esbox.common.core.sdk.ISDK#refresh()
-	 */
-	public void refresh() {
-		getCache().clear();
-		super.refresh();
-	}
-
 	/* (non-Javadoc)
 	 * @see org.maemo.esbox.scratchbox.core.sdk.IScratchboxSDK#getInstallLocation()
 	 */

Modified: branches/work_Ed/org.maemo.esbox.scratchbox.sb1/src/org/maemo/esbox/internal/scratchbox/sb1/ui/adapters/MaemoScratchbox1SDKManageTargetAdapter.java
===================================================================
--- branches/work_Ed/org.maemo.esbox.scratchbox.sb1/src/org/maemo/esbox/internal/scratchbox/sb1/ui/adapters/MaemoScratchbox1SDKManageTargetAdapter.java	2009-05-04 19:41:40 UTC (rev 1528)
+++ branches/work_Ed/org.maemo.esbox.scratchbox.sb1/src/org/maemo/esbox/internal/scratchbox/sb1/ui/adapters/MaemoScratchbox1SDKManageTargetAdapter.java	2009-05-04 19:52:05 UTC (rev 1529)
@@ -41,7 +41,7 @@
 	 * @see org.maemo.mica.common.core.adapters.ISDKManageTargetAdapter#prepareRefresh()
 	 */
 	public void prepareRefresh() {
-		sdk.getCache().clear();
+		// TODO: remove; this is already done in BaseSDK#refresh()
 	}
 	
 	/*