Alternative download link ?

Kalle Valo kalle.valo at nokia.com
Tue Jan 20 11:15:24 EET 2009


"ext Henning Rogge" <rogge at fgan.de> writes:

> While looking through some older stlc45xx code from the maemo garage I found 
> something strange:
>
> In line 1984 I found this code:
> for (i = 0; i < 8; i++) {
> 	rate = ieee80211_get_tx_rate(stlc->hw, info);
> 	data->aloft[i] = rate->hw_value;
> }
>
> If I understand this code this means that all retries will be send
> with the same transmission speed.

Correct. When I wrote that, mac80211 didn't have proper support for
multiple retransmission rates. I should have added a FIXME comment to
state this.

> Other drivers (ath5k for example) use different retry speeds to
> allow ministrel (the new rate control algorithm) to speed up txrate
> detection:
>
> drivers/net/wireless/ath5k/base.c, line 1215:
> for (i = 0; i < 3; i++) {
> 	rate = ieee80211_get_alt_retry_rate(sc->hw, info, i);
> 	if (!rate)
> 		break;
>
> 	mrr_rate[i] = rate->hw_value;
> 	mrr_tries[i] = info->control.rates[i + 1].count;
> }
>
> Would it be possible to do something for the stlc45xx too ?

Definitely. It would be excellent if someone (you?) could post a
patch.

-- 
Kalle Valo


More information about the stlc45xx-devel mailing list