Advanced search
Log In
New Account
  
Home My Page Project Cloud Code Snippets Project Openings kernel-power
Summary Tracker SCM

Bugs: Browse | Download .csv

[#6784] wl12xx constructs invalid skbs

Please login

State:
Closed
Date:
2011-01-22 13:01
Priority:
3
Submitted By:
Bernard B (bernardb)
Assigned To:
Nobody (None)
Summary:
wl12xx constructs invalid skbs

Detailed description
On the power kernel (v46), IPv6 does not work on some wireless networks  - it works for about 10 seconds, and then all
IPv6 connectivity ceases, as the kernel is rejecting neighbour advertisements.

I traced this back to an issue with the wl12xx driver. When receiving packets, the driver rounds up the packet size
to a multiple of the word size. It then adjusts skb->len to remove the alignment bytes. However it forgets to adjust
skb->tail which needs to match.

In my case, the IPv6 neighbour advertisement parsing code was looking at skb->tail, and discarding packets due to
the trailing padding bytes.

The attached patch fixes this issue by using skb_trim() to resize the skb correctly. It fixes my IPv6 issues on the
power kernel, and has not affected any other usage.

Maybe this is related to the other wireless issues people are having also?

Followup

Message
Date: 2011-08-11 14:44
Sender: Pali Rohár

Patch from https://garage.maemo.org/tracker/index.php?func=detail
&aid=6785&group_id=1528&atid=5523 is included in
kernel-power.
Date: 2011-02-26 22:40
Sender: Luke Dashjr

Confirmed this fixes IPv6.

Attached Files:

Name Download
No Files Currently Attached

Changes:

Field Old Value Date By
ResolutionNone2011-08-11 14:44pali
close_date2011-08-11 14:442011-08-11 14:44pali
status_idOpen2011-08-11 14:44pali
File Added927: wl12xx-rx-fix.diff2011-01-22 13:01bernardb

Terms of Use    Privacy Policy    Contribution Guidelines    Feedback

Powered By GForge Collaborative Development Environment