Advanced search
Log In
New Account
  
Home My Page Project Cloud Code Snippets Project Openings ESbox
Summary Forums Tracker Lists Tasks News SCM Files Wiki

Bugs: Browse | Download .csv

[#4651] In Maemo SDK VM installer, avoid launching or acquiring virtual machine until it is configured

Please login

State:
Open
Date:
2009-10-08 15:31
Priority:
4
Submitted By:
Ed Swartz (eswartz)
Assigned To:
Ed Swartz (eswartz)
Summary:
In Maemo SDK VM installer, avoid launching or acquiring virtual machine until it is configured

Detailed description
(see bug 4632 for initial discussion)

In the transition from downloading/unzipping the virtual machine image, to the point where the Build Machine preferences
are exposed, the VM may be acquired, presenting a "Launch machine?" dialog before the machine is even
configured.

I think this may be due to this call in MaemoSDKVMInstaller#configureInitialVMSettings():

MachineRegistry.getInstance().setCurrentBuildMachine(vmwareMachine);

I think this exposes an opportunity to automatically acquire the machine, via the IBuildMachineConfigurationListener
attached in SDKManager's constructor.

It may be that the VM installer wizard should pass a preconfigured IVMWareConfiguration object to the preference page
via the "Object data" field to PreferencesUtil#createPreferenceDialogOn(), rather than changing or setting
up the machine before invoking the pref dialog.

Or, it may be as simple as moving the SDKManagerInternal#lock() call before the call to #setCurrentBuildMachine().  

----

In any case, the behavior should be that there is no attempt to launch or probe the machine (no question dialogs at
all) until the user hits Launch/Validate/Apply/OK from the Build Machines page.

Followup

Message
Date: 2009-11-24 13:44
Sender: Arto Hyvarinen

Verified with Esbox_build.606.
Date: 2009-11-10 16:23
Sender: Ed Swartz

Fix in ESbox rev 2388.
Date: 2009-11-10 15:27
Sender: Ed Swartz

I think the simpler approach works fine.

Attached Files:

Name Download
No Files Currently Attached

Changes:

Field Old Value Date By
ResolutionFixed2009-11-24 13:44arhyvari
ResolutionAccepted as a Bug2009-11-10 16:23eswartz
ResolutionNone2009-11-10 15:27eswartz
assigned_tonone2009-11-10 15:27eswartz

Terms of Use    Privacy Policy    Contribution Guidelines    Feedback

Powered By GForge Collaborative Development Environment